* preempt.c not in hack-files
@ 2008-11-06 16:27 Alexander Graf
2008-11-06 16:34 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Graf @ 2008-11-06 16:27 UTC (permalink / raw)
To: KVM list; +Cc: Avi Kivity
Hi,
is there any particular reason x86/preempt.c is not in the hack-files?
When I accidently tried to compile KVM on a kernel that does not have
PREEMPT_NOTIFIERS, I got an error claiming that "on_each_cpu" is wrong.
So basically we should use kvm_on_each_cpu here, right? This
transition is done in the hack awk script, but preempt.c does not seem
like it's included there.
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: preempt.c not in hack-files
2008-11-06 16:27 preempt.c not in hack-files Alexander Graf
@ 2008-11-06 16:34 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-11-06 16:34 UTC (permalink / raw)
To: Alexander Graf; +Cc: KVM list
Alexander Graf wrote:
> Hi,
>
> is there any particular reason x86/preempt.c is not in the hack-files?
Mainly because it doesn't come from kvm.git.
> When I accidently tried to compile KVM on a kernel that does not have
> PREEMPT_NOTIFIERS, I got an error claiming that "on_each_cpu" is wrong.
>
> So basically we should use kvm_on_each_cpu here, right?
Yes, that's probably the best thing to do.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-06 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-06 16:27 preempt.c not in hack-files Alexander Graf
2008-11-06 16:34 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox