From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT Date: Thu, 06 Nov 2008 14:02:10 -0600 Message-ID: <49134D42.6080109@codemonkey.ws> References: <43a111ea61b542d3823e.1225946995@localhost.localdomain> <4912F89D.1090908@codemonkey.ws> <1225998124.8620.45.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: rusty@rustcorp.com.au, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org To: Hollis Blanchard Return-path: Received: from qw-out-2122.google.com ([74.125.92.24]:42902 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbYKFUCQ (ORCPT ); Thu, 6 Nov 2008 15:02:16 -0500 In-Reply-To: <1225998124.8620.45.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Hollis Blanchard wrote: > I wanted to make sure people on non-x86 architectures couldn't run into > vring-size related problems that didn't also appear on x86. > Having a VRING_SHIFT and a VRING_PAGE_SIZE where VRING_PAGE_SIZE != (1 << VRING_SHIFT) is almost certainly going to break things in unexpected ways because it's going against common understanding of the relationship between shift and page_size. Regards, Anthony Liguori