Re: [PATCH] kvm: ppc: fix Kconfig constraints

[Avi Kivity <avi@redhat.com>]

Hollis Blanchard wrote:
> kvm: ppc: fix Kconfig constraints
>
> Make sure that CONFIG_KVM cannot be selected without processor support
> (currently, 440 is the only processor implementation available).
>
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
>
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -15,24 +15,22 @@ if VIRTUALIZATION
>  if VIRTUALIZATION
>  
>  config KVM
> -	bool "Kernel-based Virtual Machine (KVM) support"
> -	depends on EXPERIMENTAL
> +	bool
>  	select PREEMPT_NOTIFIERS
>  	select ANON_INODES
> +
> +config KVM_440
> +	bool "KVM support for PowerPC 440 processors"
> +	depends on EXPERIMENTAL && 44x
> +	select KVM
>   

I have a vague memory that 'select' will not propagate (what's the word? 
transitive?) - -that is, the 'select KVM' will enable KVM but will not 
cause ANON_INODES and PREEMPT_NOTIFIERS to be set.

Can you check this out?

(copying Sam for a definitive statement)

-- 
error compiling committee.c: too many arguments to function