From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: ppc: fix Kconfig constraints Date: Sun, 09 Nov 2008 12:05:02 +0200 Message-ID: <4916B5CE.1080605@redhat.com> References: <7ef9d93760395985e11f.1226085033@localhost.localdomain> <1226085313.9309.26.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, Sam Ravnborg To: Hollis Blanchard Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37082 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753882AbYKIKFK (ORCPT ); Sun, 9 Nov 2008 05:05:10 -0500 In-Reply-To: <1226085313.9309.26.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Hollis Blanchard wrote: > kvm: ppc: fix Kconfig constraints > > Make sure that CONFIG_KVM cannot be selected without processor support > (currently, 440 is the only processor implementation available). > > Signed-off-by: Hollis Blanchard > > diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig > --- a/arch/powerpc/kvm/Kconfig > +++ b/arch/powerpc/kvm/Kconfig > @@ -15,24 +15,22 @@ if VIRTUALIZATION > if VIRTUALIZATION > > config KVM > - bool "Kernel-based Virtual Machine (KVM) support" > - depends on EXPERIMENTAL > + bool > select PREEMPT_NOTIFIERS > select ANON_INODES > + > +config KVM_440 > + bool "KVM support for PowerPC 440 processors" > + depends on EXPERIMENTAL && 44x > + select KVM > I have a vague memory that 'select' will not propagate (what's the word? transitive?) - -that is, the 'select KVM' will enable KVM but will not cause ANON_INODES and PREEMPT_NOTIFIERS to be set. Can you check this out? (copying Sam for a definitive statement) -- error compiling committee.c: too many arguments to function