From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] remove vcpu_info array v5 Date: Tue, 11 Nov 2008 11:26:56 +0200 Message-ID: <49194FE0.4030003@redhat.com> References: <4909C00F.8050704@sgi.com> <49103812.1070104@redhat.com> <5d6222a80811040555q5be67439sbd38d94dfa25d8ad@mail.gmail.com> <49105C95.90809@redhat.com> <5d6222a80811040635j70c57efev1f3abc5096803b29@mail.gmail.com> <49105ED8.107@redhat.com> <4918376D.6060201@sgi.com> <491839CF.9060105@redhat.com> <491857A7.1040909@sgi.com> <49185932.9010006@redhat.com> <49185A12.9000105@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Glauber Costa , Anthony Liguori , Hollis Blanchard , "kvm@vger.kernel.org" , "kvm-ia64@vger.kernel.org" To: Jes Sorensen Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45528 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751064AbYKKJ1F (ORCPT ); Tue, 11 Nov 2008 04:27:05 -0500 In-Reply-To: <49185A12.9000105@sgi.com> Sender: kvm-owner@vger.kernel.org List-ID: Jes Sorensen wrote: > Avi Kivity wrote: >> The code I mentioned only runs if the -no-kvm-irqchip option is >> passed. It's not the highest performing option... > > What I meant was that I was able to compile the code, and there was only > one piece left that needed that function, which is why I moved it and > made it static in the acpi code. > That's because there is another static array in acpi.c... >> So this isn't used a lot. But cpus definitely use cpu numbers (as >> apic ids), so qemu needs to be prepared to handle this. As to >> scalability, that takes will take a lot more work than >> removing/changing arbitrary limits. Look at qemu_mutex and weep. > > Well we have to start somewhere. Just because there's limits in other > areas too, doesn't mean we should discard valid improvements elsewhere. > I'll get to some of that at some point, but there's soo many cards used > to build this house.... Your patch builds the 16383rd floor while ignoring the 15th. Qemu scaling issues are much, much more painful than what you were addressing. -- error compiling committee.c: too many arguments to function