From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/4] add ksm kernel shared memory driver Date: Wed, 12 Nov 2008 00:43:27 +0200 Message-ID: <491A0A8F.30805@redhat.com> References: <1226409701-14831-1-git-send-email-ieidus@redhat.com> <1226409701-14831-2-git-send-email-ieidus@redhat.com> <1226409701-14831-3-git-send-email-ieidus@redhat.com> <1226409701-14831-4-git-send-email-ieidus@redhat.com> <20081111150345.7fff8ff2@bike.lwn.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Izik Eidus , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, aarcange@redhat.com, chrisw@redhat.com To: Jonathan Corbet Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56032 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984AbYKKWnX (ORCPT ); Tue, 11 Nov 2008 17:43:23 -0500 In-Reply-To: <20081111150345.7fff8ff2@bike.lwn.net> Sender: kvm-owner@vger.kernel.org List-ID: Jonathan Corbet wrote: >> +static struct list_head slots; >> > > Some of these file-static variable names seem a little..terse... > While ksm was written to be independent of a certain TLA-named kernel subsystem developed two rooms away, they share some naming... this refers to kvm 'memory slots' which correspond to DIMM banks. I guess it should be renamed to merge_ranges or something. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.