From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/4] Add replace_page(), change the mapping of pte from one page into another Date: Wed, 12 Nov 2008 12:05:56 +0200 Message-ID: <491AAA84.5040801@redhat.com> References: <1226409701-14831-1-git-send-email-ieidus@redhat.com> <1226409701-14831-2-git-send-email-ieidus@redhat.com> <1226409701-14831-3-git-send-email-ieidus@redhat.com> <20081111114555.eb808843.akpm@linux-foundation.org> <4919F1C0.2050009@redhat.com> <4919F7EE.3070501@redhat.com> <20081111222421.GL10818@random.random> <20081112111931.0e40c27d.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , Christoph Lameter , Izik Eidus , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, chrisw@redhat.com, izike@qumranet.com To: KAMEZAWA Hiroyuki Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56341 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbYKLKGK (ORCPT ); Wed, 12 Nov 2008 05:06:10 -0500 In-Reply-To: <20081112111931.0e40c27d.kamezawa.hiroyu@jp.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: KAMEZAWA Hiroyuki wrote: > Can I make a question ? (I'm working for memory cgroup.) > > Now, we do charge to anonymous page when > - charge(+1) when it's mapped firstly (mapcount 0->1) > - uncharge(-1) it's fully unmapped (mapcount 1->0) vir page_remove_rmap(). > > My quesion is > - PageKSM pages are not necessary to be tracked by memory cgroup ? > - Can we know that "the page is just replaced and we don't necessary to do > charge/uncharge". > - annonymous page from KSM is worth to be tracked by memory cgroup ? > (IOW, it's on LRU and can be swapped-out ?) > My feeling is that shared pages should be accounted as if they were not shared; that is, a share page should be accounted for each process that shares it. Perhaps sharing within a cgroup should be counted as 1 page for all the ptes pointing to it. -- error compiling committee.c: too many arguments to function