From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [patch] remove vcpu_info array v5 Date: Wed, 12 Nov 2008 14:02:28 +0100 Message-ID: <491AD3E4.3040603@sgi.com> References: <4909C00F.8050704@sgi.com> <49103812.1070104@redhat.com> <5d6222a80811040555q5be67439sbd38d94dfa25d8ad@mail.gmail.com> <49105C95.90809@redhat.com> <5d6222a80811040635j70c57efev1f3abc5096803b29@mail.gmail.com> <49105ED8.107@redhat.com> <4918376D.6060201@sgi.com> <491839CF.9060105@redhat.com> <491857A7.1040909@sgi.com> <49185932.9010006@redhat.com> <49185A12.9000105@sgi.com> <49194FE0.4030003@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Glauber Costa , Anthony Liguori , Hollis Blanchard , "kvm@vger.kernel.org" , "kvm-ia64@vger.kernel.org" To: Avi Kivity Return-path: Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:49648 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751826AbYKLNCe (ORCPT ); Wed, 12 Nov 2008 08:02:34 -0500 In-Reply-To: <49194FE0.4030003@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Jes Sorensen wrote: >> What I meant was that I was able to compile the code, and there was only >> one piece left that needed that function, which is why I moved it and >> made it static in the acpi code. >> > > That's because there is another static array in acpi.c... Which array are you talking about? ACPI has it's own limitations, like we need ACPI 3.0 to go beyond 256 processors :-( >> Well we have to start somewhere. Just because there's limits in other >> areas too, doesn't mean we should discard valid improvements elsewhere. >> I'll get to some of that at some point, but there's soo many cards used >> to build this house.... > > Your patch builds the 16383rd floor while ignoring the 15th. Qemu > scaling issues are much, much more painful than what you were addressing. Well I am not ignoring the 15th floor, I am just putting in expandable rails that can go all the way to the 16383rd. Next I'll get to look at putting in the button to make the elevator stop at the 15th+ floors :) Cheers, Jes