From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [ANNOUNCE] kvm-79 release
Date: Wed, 12 Nov 2008 16:55:54 +0200
Message-ID: <491AEE7A.5010806@redhat.com>
References: <491AEDEF.4010105@itwm.fraunhofer.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Martin Vogt <vogt@itwm.fraunhofer.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:41602 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752442AbYKLO4E (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 12 Nov 2008 09:56:04 -0500
In-Reply-To: <491AEDEF.4010105@itwm.fraunhofer.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Martin Vogt wrote:
> Hello,
>
>
> [...]
>   
>> Notes:
>> If you use the modules bundled with kvm-79, you can use any version
>> of Linux from 2.6.16 upwards.
>>     
>
> Nope.
> I tested kvm-79 on a SLES 10 with 2.6.16,
> in the hope that my previously reported bug:
>
> "hrtimer_start: Unknown symbol in module"
>
> was fixed. (It wasnt)
>
> Now I have this "one-liner patch(tm)" here which works for me:
>
>
> diff -u external-module-compat-comm.h.org external-module-compat-comm.h
> --- external-module-compat-comm.h.org   2008-11-12 15:51:55.000000000 +0100
> +++ external-module-compat-comm.h       2008-11-12 15:52:05.000000000 +0100
> @@ -601,7 +601,7 @@
>
>  static inline void hrtimer_start_expires(struct hrtimer *timer, int mode)
>  {
> -       hrtimer_start(timer, timer->expires, mode);
> +       hrtimer_start_p(timer, timer->expires, mode);
>  }
>
>
>
> Is this a correct fix?
>
>   

It is correct -- I added hrtimer_start_expires without taking 2.6.16 
into account.

> - I could boot suse 11.1 beta4 with it(which didnt work with kvm-77)
>
> Im really not sure if this works corretly and I dont want have broken
> modules in my kernel :(
>
> Is hrtimer_start_p already initialized when  hrtimer_start_expires is
> called? (help)
>   

Yes, hrtimer_start_p is initialized very early on.

Please send a signed-off-by line and I will apply.


-- 
error compiling committee.c: too many arguments to function