From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] KVM: VMX: Clean up private memory slot allocation Date: Thu, 13 Nov 2008 14:27:13 +0200 Message-ID: <491C1D21.5090501@redhat.com> References: <1226388688-32247-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54176 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbYKMM1R (ORCPT ); Thu, 13 Nov 2008 07:27:17 -0500 In-Reply-To: <1226388688-32247-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > userspace_addr should be a meaningless value. > Perhaps in __kvm_set_memory_region(), if !user_alloc? Why is it needed? Did you observe any problem? > @@ -2022,6 +2022,8 @@ static int alloc_apic_access_page(struct kvm *kvm) > kvm_userspace_mem.flags = 0; > kvm_userspace_mem.guest_phys_addr = 0xfee00000ULL; > kvm_userspace_mem.memory_size = PAGE_SIZE; > + /* userspace_addr is invalid, make it unaligned */ > + kvm_userspace_mem.userspace_addr = PAGE_SIZE - 1; > r = __kvm_set_memory_region(kvm, &kvm_userspace_mem, 0); > if (r) > goto out; > @@ -2044,6 +2046,8 @@ static int alloc_identity_pagetable(struct kvm *kvm) > kvm_userspace_mem.flags = 0; > kvm_userspace_mem.guest_phys_addr = VMX_EPT_IDENTITY_PAGETABLE_ADDR; > kvm_userspace_mem.memory_size = PAGE_SIZE; > + /* userspace_addr is invalid, make it unaligned */ > + kvm_userspace_mem.userspace_addr = PAGE_SIZE - 1; > r = __kvm_set_memory_region(kvm, &kvm_userspace_mem, 0); > if (r) > goto out; > -- error compiling committee.c: too many arguments to function