public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@sgi.com>
To: Avi Kivity <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
	Weidong Han <weidong.han@intel.com>
Subject: [patch] fix kvm-userland on ia64
Date: Thu, 13 Nov 2008 15:02:38 +0100	[thread overview]
Message-ID: <491C337E.1060109@sgi.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Hi,

Patch 6cb7f4d86438f56a5c917ff6148c70bd237ee0e5 introduced an
unconditional call to kvm_arch_do_ioperm() without protecting
with an #ifdef like the remaining calls are.

Cheers,
Jes

[-- Attachment #2: 0001-kvm-qemufix-ioperm-build.patch --]
[-- Type: text/plain, Size: 1077 bytes --]

Protect calls to kvm_arch_do_ioperm() introduced in
6cb7f4d86438f56a5c917ff6148c70bd237ee0e5 with
#ifdef USE_KVM_DEVICE_ASSIGNMENT similar to how the other calls to
this function are protected.

Signed-off-by: Jes Sorensen <jes@sgi.com>


---
 qemu/qemu-kvm.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: kvm-userspace.git/qemu/qemu-kvm.c
===================================================================
--- kvm-userspace.git.orig/qemu/qemu-kvm.c
+++ kvm-userspace.git/qemu/qemu-kvm.c
@@ -444,7 +444,7 @@
 {
     CPUState *env = _env;
     sigset_t signals;
-    struct ioperm_data *data;
+    struct ioperm_data *data = NULL;
 
     vcpu = &vcpu_info[env->cpu_index];
     vcpu->env = env;
@@ -454,9 +454,11 @@
     kvm_create_vcpu(kvm_context, env->cpu_index);
     kvm_qemu_init_env(env);
 
+#ifdef USE_KVM_DEVICE_ASSIGNMENT
     /* do ioperm for io ports of assigned devices */
     LIST_FOREACH(data, &ioperm_head, entries)
 	on_vcpu(env, kvm_arch_do_ioperm, data);
+#endif
 
     /* signal VCPU creation */
     pthread_mutex_lock(&qemu_mutex);

             reply	other threads:[~2008-11-13 14:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 14:02 Jes Sorensen [this message]
2008-11-13 14:06 ` [patch] fix kvm-userland on ia64 Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491C337E.1060109@sgi.com \
    --to=jes@sgi.com \
    --cc=avi@redhat.com \
    --cc=kvm-ia64@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=weidong.han@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox