From: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Eduardo Habkost <ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
Zachary Amsden <zach-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
Haren Myneni <hbabu-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>,
Andrey Borzenkov <arvidjaar-JGs/UdohzUI@public.gmane.org>,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 00/11] x86: disable virt on kdump and emergency_restart (v3)
Date: Sun, 16 Nov 2008 09:57:55 +0200 [thread overview]
Message-ID: <491FD283.60402@redhat.com> (raw)
In-Reply-To: <1226598231-18311-1-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Eduardo Habkost wrote:
> Hi,
>
> This is a new spin of the series to disable vmx on kdump and on
> emergency_restart. Now we avoid doing the function pointer stuff by
> moving 4 small KVM functions to a header, as inline functions. The code
> looks much simpler now, but we have to be more careful because some
> additional code will run on kdump and reboot even when KVM is never
> loaded.
>
> I haven't tested the SVM changes on AMD CPUs. The changes are really
> simple, but some testing is welcome.
>
> This series is against tip.git#master, that already contains the
> nmi_shootdown_cpus() changes I've submitted previously.
>
>
>
Looks good. I am slightly uneasy about moving things away from vmx.h
and svm.h; can we keep them there and #include those headers directly?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-16 7:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 17:43 [PATCH 00/11] x86: disable virt on kdump and emergency_restart (v3) Eduardo Habkost
2008-11-13 17:43 ` [PATCH 01/11] kvm: vmx: move cpu_has_kvm_support() to an inline on asm/virtext.h Eduardo Habkost
2008-11-13 17:43 ` [PATCH 02/11] kvm: vmx: move ASM_VMX_* definitions to asm/virtext.h Eduardo Habkost
2008-11-13 17:43 ` [PATCH 03/11] x86: asm/virtext.h: add cpu_vmxoff() inline function Eduardo Habkost
2008-11-13 17:43 ` [PATCH 04/11] kvm: vmx: extract kvm_cpu_vmxoff() from hardware_disable() Eduardo Habkost
2008-11-13 17:43 ` [PATCH 05/11] x86: cpu_emergency_vmxoff() function Eduardo Habkost
2008-11-13 17:43 ` [PATCH 06/11] kvm: svm: move some SVM_* #defines to asm/virtext.h Eduardo Habkost
2008-11-13 17:43 ` [PATCH 07/11] kvm: svm: move has_svm() code " Eduardo Habkost
2008-11-13 17:43 ` [PATCH 08/11] kvm: svm: move svm_hardware_disable() " Eduardo Habkost
2008-11-13 17:43 ` [PATCH 09/11] x86: asm/virtext.h: create cpu_emergency_svm_disable() Eduardo Habkost
2008-11-13 17:43 ` [PATCH 10/11] kdump: forcibly disable VMX and SVM on machine_crash_shutdown() Eduardo Habkost
2008-11-13 17:43 ` [PATCH 11/11] x86: disable VMX on all CPUs on reboot Eduardo Habkost
[not found] ` <1226598231-18311-1-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-11-16 7:57 ` Avi Kivity [this message]
[not found] ` <491FD283.60402-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-11-17 15:04 ` [PATCH 00/11] x86: disable virt on kdump and emergency_restart (v3) Eduardo Habkost
2008-11-17 15:12 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491FD283.60402@redhat.com \
--to=avi-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=akpm-3NddpPZAyC0@public.gmane.org \
--cc=arvidjaar-JGs/UdohzUI@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hbabu-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=zach-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox