From: Avi Kivity <avi@redhat.com>
To: "Kamble, Nitin A" <nitin.a.kamble@intel.com>
Cc: "Nakajima, Jun" <jun.nakajima@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"chrisw@sous-sol.org" <chrisw@sous-sol.org>
Subject: Re: [Patch 3] thread/core siblings info for guests
Date: Sun, 16 Nov 2008 15:26:38 +0200 [thread overview]
Message-ID: <49201F8E.9010709@redhat.com> (raw)
In-Reply-To: <8EA2C2C4116BF44AB370468FBF85A777A68E2655@orsmsx504.amr.corp.intel.com>
Kamble, Nitin A wrote:
>> The capability itself can return the count; for example
>>
>> case KVM_CAP_NR_CPUID_LEAVES:
>> return KVM_MAX_CPUID_ENTRIES;
>>
>> which is simpler to use and shorter.
>>
>
> Avi,
> Yes, it is simpler and shorter, but is returning a constant. It will be wasting space for the unused entries. Also it put's a restriction that the list count can not go more than that.
> The dynamic size finding, the patch I sent, is not complicated or long to be an issue. Would you like to give another consideration for the same patch (patch-3) I sent earlier?
>
>
Oh, I confused the sizing code with something else.
We can add this, but older kernels will still miss the code so we have
to work around it. I guess userspace can start with a large number, and
double it each time the ioctl fails.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-16 13:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 20:35 thread/core siblings info for guests Kamble, Nitin A
2008-10-05 9:44 ` Avi Kivity
2008-10-06 10:23 ` Gerd Hoffmann
2008-10-06 18:01 ` Kamble, Nitin A
2008-10-06 20:54 ` Chris Wright
2008-10-17 22:45 ` Nitin A Kamble
2008-10-18 0:18 ` Alexander Graf
2008-10-20 16:46 ` Kamble, Nitin A
2008-10-19 9:29 ` Avi Kivity
2008-10-20 18:37 ` Nitin A Kamble
2008-10-21 8:52 ` Avi Kivity
2008-10-31 16:47 ` Nitin A Kamble
2008-11-04 14:59 ` Avi Kivity
2008-11-04 19:02 ` Nitin A Kamble
2008-11-05 6:38 ` Avi Kivity
2008-11-05 23:37 ` [Patch 1] " Nitin A Kamble
2008-11-06 13:10 ` Avi Kivity
2008-11-05 23:56 ` [patch 2] " Nitin A Kamble
2008-11-06 13:18 ` Avi Kivity
2008-11-06 0:25 ` [Patch 3] " Nitin A Kamble
2008-11-06 13:20 ` Avi Kivity
2008-11-06 18:01 ` Kamble, Nitin A
2008-11-16 13:26 ` Avi Kivity [this message]
2008-11-18 0:09 ` Nitin A Kamble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49201F8E.9010709@redhat.com \
--to=avi@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=jun.nakajima@intel.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nitin.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).