From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] bios: resolve memory device roll over reporting issues with >32G guests Date: Sun, 16 Nov 2008 18:09:58 +0200 Message-ID: <492045D6.1060803@redhat.com> References: <491456C7.860B.008B.3@novell.com> <4916E275.2000802@redhat.com> <4917FF62.860B.008B.3@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Bill Rieske Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56593 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753513AbYKPQKD (ORCPT ); Sun, 16 Nov 2008 11:10:03 -0500 In-Reply-To: <4917FF62.860B.008B.3@novell.com> Sender: kvm-owner@vger.kernel.org List-ID: Bill Rieske wrote: >> Instead of this, can you add an snprintf() (in a separate patch) and use >> it? There's already a vsnprintf() so all the heavy machinery is in place. >> > Nice catch much cleaner > > The field within the Memory Device type 17 is only a word with the MSB being > used to report MB/KB. Thereby, a guest with 32G and greater would report > incorrect memory device information rolling over to 0. > This presents more than one memory device and associated memory structures > if the memory is larger than 16G > > Applied, thanks. -- error compiling committee.c: too many arguments to function