From: Avi Kivity <avi@redhat.com>
To: "Han, Weidong" <weidong.han@intel.com>
Cc: "'kvm@vger.kernel.org'" <kvm@vger.kernel.org>,
"Kay, Allen M" <allen.m.kay@intel.com>,
"Yang, Sheng" <sheng.yang@intel.com>
Subject: Re: [PATCH 1/4] KVM: support VT-d device hotplug
Date: Mon, 17 Nov 2008 16:48:34 +0200 [thread overview]
Message-ID: <49218442.9090900@redhat.com> (raw)
In-Reply-To: <715D42877B251141A38726ABF5CABF2C018BE64D93@pdsmsx503.ccr.corp.intel.com>
Han, Weidong wrote:
>> This is how KVM_CAP_ works:
>>
>> - kvm.h defines KVM_CAP_DEVICE_ASSIGNMENT
>> - userspace compiles device assignment code only if it sees
>> KVM_CAP_DEVICE_ASSIGNMENT in kvm.h
>> - kvm.ko returns nonzero to ioctl(KVM_CHECK_EXTENSION,
>> KVM_CAP_DEVICE_ASSIGNMENT) if it supports device assignment (recent
>> enough module, iommu found)
>> - userspace runs device assignment code only if above ioctl passes
>>
>> We need something similar to deassignment, since it didn't arrive at
>> the same time as assignment.
>>
>
> In my patches, deassignment already does the similar thing as assignment. Can you point out where it is missed?
>
It needs a new KVM_CAP_ symbol. 2.6.28 has KVM_CAP_DEVICE_ASSIGNMENT
defined, but will not have the deassignment code.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-17 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 9:23 [PATCH 1/4] KVM: support VT-d device hotplug Han, Weidong
2008-11-16 8:05 ` Avi Kivity
2008-11-17 9:16 ` Han, Weidong
2008-11-17 10:28 ` Avi Kivity
2008-11-17 13:31 ` Han, Weidong
2008-11-17 14:05 ` Avi Kivity
2008-11-17 14:21 ` Han, Weidong
2008-11-17 14:48 ` Avi Kivity [this message]
2008-11-18 3:31 ` Han, Weidong
2008-11-18 12:40 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49218442.9090900@redhat.com \
--to=avi@redhat.com \
--cc=allen.m.kay@intel.com \
--cc=kvm@vger.kernel.org \
--cc=sheng.yang@intel.com \
--cc=weidong.han@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox