From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/4] KVM: support VT-d device hotplug Date: Mon, 17 Nov 2008 16:48:34 +0200 Message-ID: <49218442.9090900@redhat.com> References: <715D42877B251141A38726ABF5CABF2C018BE64962@pdsmsx503.ccr.corp.intel.com> <491FD45A.9070309@redhat.com> <715D42877B251141A38726ABF5CABF2C018BE64D26@pdsmsx503.ccr.corp.intel.com> <4921475B.5010403@redhat.com> <715D42877B251141A38726ABF5CABF2C018BE64D7E@pdsmsx503.ccr.corp.intel.com> <49217A3D.709@redhat.com> <715D42877B251141A38726ABF5CABF2C018BE64D93@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "'kvm@vger.kernel.org'" , "Kay, Allen M" , "Yang, Sheng" To: "Han, Weidong" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43372 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbYKQOsn (ORCPT ); Mon, 17 Nov 2008 09:48:43 -0500 In-Reply-To: <715D42877B251141A38726ABF5CABF2C018BE64D93@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Han, Weidong wrote: >> This is how KVM_CAP_ works: >> >> - kvm.h defines KVM_CAP_DEVICE_ASSIGNMENT >> - userspace compiles device assignment code only if it sees >> KVM_CAP_DEVICE_ASSIGNMENT in kvm.h >> - kvm.ko returns nonzero to ioctl(KVM_CHECK_EXTENSION, >> KVM_CAP_DEVICE_ASSIGNMENT) if it supports device assignment (recent >> enough module, iommu found) >> - userspace runs device assignment code only if above ioctl passes >> >> We need something similar to deassignment, since it didn't arrive at >> the same time as assignment. >> > > In my patches, deassignment already does the similar thing as assignment. Can you point out where it is missed? > It needs a new KVM_CAP_ symbol. 2.6.28 has KVM_CAP_DEVICE_ASSIGNMENT defined, but will not have the deassignment code. -- error compiling committee.c: too many arguments to function