From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/4] KVM: support VT-d device hotplug Date: Tue, 18 Nov 2008 14:40:11 +0200 Message-ID: <4922B7AB.8050905@redhat.com> References: <715D42877B251141A38726ABF5CABF2C018BE64962@pdsmsx503.ccr.corp.intel.com> <491FD45A.9070309@redhat.com> <715D42877B251141A38726ABF5CABF2C018BE64D26@pdsmsx503.ccr.corp.intel.com> <4921475B.5010403@redhat.com> <715D42877B251141A38726ABF5CABF2C018BE64D7E@pdsmsx503.ccr.corp.intel.com> <49217A3D.709@redhat.com> <715D42877B251141A38726ABF5CABF2C018BE64D93@pdsmsx503.ccr.corp.intel.com> <49218442.9090900@redhat.com> <715D42877B251141A38726ABF5CABF2C018BE64EEA@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "'kvm@vger.kernel.org'" , "Kay, Allen M" , "Yang, Sheng" To: "Han, Weidong" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55245 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbYKRMkQ (ORCPT ); Tue, 18 Nov 2008 07:40:16 -0500 In-Reply-To: <715D42877B251141A38726ABF5CABF2C018BE64EEA@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Han, Weidong wrote: > In fact, without multiple device assignment, VT-d hotplug cannot be supported cleanly. Given hot add a device under a different iommu, it will be mapped in a wrong iommu, thus it won't work. I will start to implement multiple device assignment first. > Yes, the 2.6.28 implementation has some weaknesses. Please work with Joerg Roedel so that it fits within his iommu api. -- error compiling committee.c: too many arguments to function