From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] pass opague CPUState through libkvm instead of int vcpu Date: Tue, 18 Nov 2008 14:55:02 +0200 Message-ID: <4922BB26.4020308@redhat.com> References: <4909C00F.8050704@sgi.com> <49103812.1070104@redhat.com> <491835FF.9030400@sgi.com> <49183BB8.7080502@redhat.com> <491C59DD.6070005@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Hollis Blanchard , "kvm@vger.kernel.org" , "kvm-ia64@vger.kernel.org" , Glauber de Oliveira Costa To: Jes Sorensen Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55917 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbYKRMz1 (ORCPT ); Tue, 18 Nov 2008 07:55:27 -0500 In-Reply-To: <491C59DD.6070005@sgi.com> Sender: kvm-owner@vger.kernel.org List-ID: Jes Sorensen wrote: > I pulled out the part of the patch that does the opague 'env' pointer. > It should be pretty straight forward - the vcpu_info patch will go on > top of this, but I'll work on that tomorrow. > > Let me know what you think - this is about as small I can make this > patch :-) It's good; applied, thanks. There's a slight redundancy in that some callbacks are passed two opaques (per-cpu and per-vm), but it won't kill anyone. (btw, this could have been done much more simply: declare a thread local variable to hold the current env) -- error compiling committee.c: too many arguments to function