public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] remove unnecessary bool from qemu-kvm.c
@ 2008-11-14 15:45 Jes Sorensen
  2008-11-18 12:56 ` Avi Kivity
  0 siblings, 1 reply; 2+ messages in thread
From: Jes Sorensen @ 2008-11-14 15:45 UTC (permalink / raw)
  To: Avi Kivity, kvm@vger.kernel.org

[-- Attachment #1: Type: text/plain, Size: 116 bytes --]

Hi,

In support of Avi's preference for half line patches, I split out the
bool eliminating bits too.

Cheers,
Jes


[-- Attachment #2: 0008-qemu-no-bool-type.patch --]
[-- Type: text/plain, Size: 648 bytes --]

Replace unnecessary use of _Bool type with int.

Signed-off-by: Jes Sorensen <jes@sgi.com>

---
 qemu/qemu-kvm.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: kvm-userspace.git/qemu/qemu-kvm.c
===================================================================
--- kvm-userspace.git.orig/qemu/qemu-kvm.c
+++ kvm-userspace.git/qemu/qemu-kvm.c
@@ -28,7 +28,6 @@
 #include <sys/syscall.h>
 #include <sys/mman.h>
 
-#define bool _Bool
 #define false 0
 #define true 1
 
@@ -53,7 +52,7 @@
     struct qemu_kvm_work_item *next;
     void (*func)(void *data);
     void *data;
-    bool done;
+    int done;
 };
 
 struct vcpu_info {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] remove unnecessary bool from qemu-kvm.c
  2008-11-14 15:45 [patch] remove unnecessary bool from qemu-kvm.c Jes Sorensen
@ 2008-11-18 12:56 ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-11-18 12:56 UTC (permalink / raw)
  To: Jes Sorensen; +Cc: kvm@vger.kernel.org

Jes Sorensen wrote:
> In support of Avi's preference for half line patches, I split out the
> bool eliminating bits too.
>

I actually like _Bool, but as we're trying to close the gap with qemu, I 
applied this patch.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-18 12:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-14 15:45 [patch] remove unnecessary bool from qemu-kvm.c Jes Sorensen
2008-11-18 12:56 ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox