From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [patch] pass opague CPUState through libkvm instead of int vcpu Date: Tue, 18 Nov 2008 13:59:18 +0100 Message-ID: <4922BC26.1050504@sgi.com> References: <4909C00F.8050704@sgi.com> <49103812.1070104@redhat.com> <491835FF.9030400@sgi.com> <49183BB8.7080502@redhat.com> <491C59DD.6070005@sgi.com> <4922BB26.4020308@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Hollis Blanchard , "kvm@vger.kernel.org" , "kvm-ia64@vger.kernel.org" , Glauber de Oliveira Costa To: Avi Kivity Return-path: Received: from relay1.sgi.com ([192.48.179.29]:35317 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751671AbYKRM70 (ORCPT ); Tue, 18 Nov 2008 07:59:26 -0500 In-Reply-To: <4922BB26.4020308@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Jes Sorensen wrote: > It's good; applied, thanks. > > There's a slight redundancy in that some callbacks are passed two > opaques (per-cpu and per-vm), but it won't kill anyone. > > (btw, this could have been done much more simply: declare a thread local > variable to hold the current env) The thread local current env is coming in the vcpu_info merge patch :-) Cheers, Jes