public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: "kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: IA64: Using CFLAGS_vcpu.o to compile vcpu.c
Date: Thu, 20 Nov 2008 13:05:19 +0200	[thread overview]
Message-ID: <4925446F.10709@redhat.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC219B28D98@pdsmsx503.ccr.corp.intel.com>

Zhang, Xiantao wrote:
>> Can you provide more information on how this was only discovered now?
>> Was there a change in mainline that removed support for EXTRA_CFLAGS?]
>>     
> It should be an old issue we didn't sense before.  To specify single object's compile option, only CFLAGS can work in this case. 

How did we not notice the issue?  What is the effect of the missing flags?

It seems like a critical problem that should prevent kvm from working at 
all, so I don't understand how it was discovered so late.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2008-11-20 11:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-20  2:43 [PATCH] KVM: IA64: Using CFLAGS_vcpu.o to compile vcpu.c Zhang, Xiantao
2008-11-20 10:50 ` Avi Kivity
2008-11-20 11:03   ` Zhang, Xiantao
2008-11-20 11:05     ` Avi Kivity [this message]
2008-11-20 11:54       ` Zhang, Xiantao
2008-11-20 12:23         ` Avi Kivity
2008-11-20 15:04           ` Zhang, Xiantao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4925446F.10709@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm-ia64@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=xiantao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox