From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH 07/12] Add VMRUN handler v6 Date: Fri, 21 Nov 2008 16:26:20 +0100 Message-ID: <4926D31C.2060001@suse.de> References: <1227280482-25361-1-git-send-email-agraf@suse.de> <1227280482-25361-2-git-send-email-agraf@suse.de> <1227280482-25361-3-git-send-email-agraf@suse.de> <1227280482-25361-4-git-send-email-agraf@suse.de> <1227280482-25361-5-git-send-email-agraf@suse.de> <1227280482-25361-6-git-send-email-agraf@suse.de> <1227280482-25361-7-git-send-email-agraf@suse.de> <1227280482-25361-8-git-send-email-agraf@suse.de> <20081121152320.GF26684@il.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, joro@8bytes.org, anthony@codemonkey.ws, avi@redhat.com To: Muli Ben-Yehuda Return-path: Received: from mx2.suse.de ([195.135.220.15]:53271 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753748AbYKUP0W (ORCPT ); Fri, 21 Nov 2008 10:26:22 -0500 In-Reply-To: <20081121152320.GF26684@il.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Muli Ben-Yehuda wrote: > On Fri, Nov 21, 2008 at 04:14:37PM +0100, Alexander Graf wrote: > > >> +static int vmrun_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run) >> +{ >> + nsvm_printk("VMrun\n"); >> + if (nested_svm_check_permissions(svm)) >> + return 1; >> + >> + svm->next_rip = kvm_rip_read(&svm->vcpu) + 3; >> + skip_emulated_instruction(&svm->vcpu); >> + >> + if (nested_svm_do(svm, svm->vmcb->save.rax, 0, >> + NULL, nested_svm_vmrun)) >> + return 1; >> + >> + if (nested_svm_do(svm, svm->vmcb->control.msrpm_base_pa, 0, >> + NULL, nested_svm_vmrun_msrpm)) >> + return 1; >> > > nested_svm_vmrun returns 1 unconditionally, so we never call > nested_svm_vmrun_msrpm. > Wow the one thing you pointed out earlier. I must've missed to write that on my TODO list. I'll fix this right now :). Await v7 any second now. Alex