Re: [PATCH 03/11] KVM: Replace irq_requested with more generic irq_requested_type

[Avi Kivity <avi@redhat.com>]

Sheng Yang wrote:
> Separate guest irq type and host irq type, for we can support guest using INTx
> with host using MSI (but not opposite combination).
>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
>  include/linux/kvm_host.h |    4 +++-
>  virt/kvm/kvm_main.c      |    9 +++++----
>  2 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 3a0fb77..c3d4b96 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -307,7 +307,9 @@ struct kvm_assigned_dev_kernel {
>  	int host_devfn;
>  	int host_irq;
>  	int guest_irq;
> -	int irq_requested;
> +#define KVM_ASSIGNED_DEV_GUEST_INTX	(1 << 0)
> +#define KVM_ASSIGNED_DEV_HOST_INTX	(1 << 8)
> +	unsigned long irq_requested_type;
>  	int irq_source_id;
>  	struct pci_dev *dev

Any particular reason the bits were not assigned sequentially?

-- 
error compiling committee.c: too many arguments to function