From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 03/11] KVM: Replace irq_requested with more generic irq_requested_type Date: Sun, 23 Nov 2008 12:07:58 +0200 Message-ID: <49292B7E.1030603@redhat.com> References: <1227095114-13792-1-git-send-email-sheng@linux.intel.com> <1227095114-13792-4-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43975 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755915AbYKWKIC (ORCPT ); Sun, 23 Nov 2008 05:08:02 -0500 In-Reply-To: <1227095114-13792-4-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > Separate guest irq type and host irq type, for we can support guest using INTx > with host using MSI (but not opposite combination). > > Signed-off-by: Sheng Yang > --- > include/linux/kvm_host.h | 4 +++- > virt/kvm/kvm_main.c | 9 +++++---- > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 3a0fb77..c3d4b96 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -307,7 +307,9 @@ struct kvm_assigned_dev_kernel { > int host_devfn; > int host_irq; > int guest_irq; > - int irq_requested; > +#define KVM_ASSIGNED_DEV_GUEST_INTX (1 << 0) > +#define KVM_ASSIGNED_DEV_HOST_INTX (1 << 8) > + unsigned long irq_requested_type; > int irq_source_id; > struct pci_dev *dev Any particular reason the bits were not assigned sequentially? -- error compiling committee.c: too many arguments to function