From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 07/11] x86: Rename MSI macro name Date: Sun, 23 Nov 2008 12:12:54 +0200 Message-ID: <49292CA6.4060102@redhat.com> References: <1227095114-13792-1-git-send-email-sheng@linux.intel.com> <1227095114-13792-8-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:39523 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752482AbYKWKM6 (ORCPT ); Sun, 23 Nov 2008 05:12:58 -0500 In-Reply-To: <1227095114-13792-8-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > Signed-off-by: Sheng Yang > --- > arch/x86/include/asm/msidef.h | 4 ++-- > arch/x86/kernel/io_apic.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/include/asm/msidef.h b/arch/x86/include/asm/msidef.h > index 6706b30..988cb27 100644 > --- a/arch/x86/include/asm/msidef.h > +++ b/arch/x86/include/asm/msidef.h > @@ -15,8 +15,8 @@ > MSI_DATA_VECTOR_MASK) > > #define MSI_DATA_DELIVERY_MODE_SHIFT 8 > -#define MSI_DATA_DELIVERY_FIXED (0 << MSI_DATA_DELIVERY_MODE_SHIFT) > -#define MSI_DATA_DELIVERY_LOWPRI (1 << MSI_DATA_DELIVERY_MODE_SHIFT) > +#define MSI_DATA_DELIVERY_FIXED_BIT (0 << MSI_DATA_DELIVERY_MODE_SHIFT) > +#define MSI_DATA_DELIVERY_LOWPRI_BIT (1 << MSI_DATA_DELIVERY_MODE_SHIFT) > These are usually named _MASK, not _BIT. But I recommend dropping this patch, it can only cause conflicts with other development. -- error compiling committee.c: too many arguments to function