From: Avi Kivity <avi@redhat.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm-ppc <kvm-ppc@vger.kernel.org>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm: ppc: stop leaking host memory on VM exit
Date: Tue, 25 Nov 2008 13:00:59 +0200 [thread overview]
Message-ID: <492BDAEB.7060601@redhat.com> (raw)
In-Reply-To: <1227548258.17746.11.camel@localhost.localdomain>
Hollis Blanchard wrote:
> When the VM exits, we must call put_page() for every page referenced in the
> shadow TLB.
>
> Without this patch, we usually leak 30-50 host pages (120 - 200 KiB with 4 KiB
> pages). The maximum number of pages leaked is the size of our shadow TLB, 64
> pages.
>
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> ---
> The obvious question is "why didn't we see this before?" Basically, we'd never
> looked for it, and since most of our work was in the kernel we always ended up
> rebooting before exhausting host memory.
>
> Since it's such a large leak, and a simple fix, please commit this for 2.6.28.
> This patch does apply to kvm.git with fuzz, but if you prefer I can send a
> separate patch for that later.
>
Applied on both master and the 2.6.28 queue.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-11-25 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 17:37 [PATCH] kvm: ppc: stop leaking host memory on VM exit Hollis Blanchard
[not found] ` <1227548258.17746.11.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-11-25 2:28 ` Liu Yu
2008-11-25 8:32 ` Liu Yu
[not found] ` <D8176E55B81822498D63816C4ADC701023423D-bKEhWGtIRUJ4Lp7cDGe+DVjVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2008-11-25 16:52 ` Hollis Blanchard
2008-11-25 11:00 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492BDAEB.7060601@redhat.com \
--to=avi@redhat.com \
--cc=hollisb@us.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox