From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: ppc: stop leaking host memory on VM exit Date: Tue, 25 Nov 2008 13:00:59 +0200 Message-ID: <492BDAEB.7060601@redhat.com> References: <1227548258.17746.11.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-ppc , kvm To: Hollis Blanchard Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40768 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbYKYLBI (ORCPT ); Tue, 25 Nov 2008 06:01:08 -0500 In-Reply-To: <1227548258.17746.11.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Hollis Blanchard wrote: > When the VM exits, we must call put_page() for every page referenced in the > shadow TLB. > > Without this patch, we usually leak 30-50 host pages (120 - 200 KiB with 4 KiB > pages). The maximum number of pages leaked is the size of our shadow TLB, 64 > pages. > > Signed-off-by: Hollis Blanchard > --- > The obvious question is "why didn't we see this before?" Basically, we'd never > looked for it, and since most of our work was in the kernel we always ended up > rebooting before exhausting host memory. > > Since it's such a large leak, and a simple fix, please commit this for 2.6.28. > This patch does apply to kvm.git with fuzz, but if you prefer I can send a > separate patch for that later. > Applied on both master and the 2.6.28 queue. -- error compiling committee.c: too many arguments to function