From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: MMU: optimize set_spte for page sync Date: Tue, 25 Nov 2008 16:38:13 +0200 Message-ID: <492C0DD5.7070206@redhat.com> References: <20081121184927.GA20607@dmt.cnet> <4929322D.7050503@redhat.com> <20081124120423.GB4379@dmt.cnet> <20081124132306.GA13532@dmt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:50578 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbYKYOiT (ORCPT ); Tue, 25 Nov 2008 09:38:19 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAPEcG2U009324 for ; Tue, 25 Nov 2008 09:38:16 -0500 In-Reply-To: <20081124132306.GA13532@dmt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > *shadow_pte can point to a different page if the guest updates > pagetable, there is a fault before resync, the fault updates the > spte with new gfn (and pfn) via mmu_set_spte. In which case the gfn > cache is updated since: > > } else if (pfn != spte_to_pfn(*shadow_pte)) { > printk("hfn old %lx new %lx\n", > spte_to_pfn(*shadow_pte), pfn); > rmap_remove(vcpu->kvm, shadow_pte); > Okay. Please resend but without the reversal of can_unsync, it will make a more readable patch. If you like, send a follow on that only does the reversal. -- error compiling committee.c: too many arguments to function