From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 05/11] KVM: Add fields for MSI device assignment Date: Tue, 25 Nov 2008 16:46:53 +0200 Message-ID: <492C0FDD.8000609@redhat.com> References: <1227095114-13792-1-git-send-email-sheng@linux.intel.com> <1227095114-13792-6-git-send-email-sheng@linux.intel.com> <49292C27.7030206@redhat.com> <200811240951.14758.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:34986 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbYKYOrA (ORCPT ); Tue, 25 Nov 2008 09:47:00 -0500 In-Reply-To: <200811240951.14758.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: >>> union { >>> + struct { >>> + __u32 addr_lo; >>> + __u32 addr_hi; >>> >> __u64 addr; >> >> ? >> > > Here I followed the spec that distinguish the "Message Address" and "Message > Upper address". And the native Linux structure: > > struct msi_msg { > u32 address_lo; /* low 32 bits of msi message address */ > u32 address_hi; /* high 32 bits of msi message address */ > u32 data; /* 16 bits of msi message data */ > }; > > For now, we needn't care about address_hi. I can only see address_hi used in > hypertransport part... So I think keep it independence here is OK. > > Fair enough, documentation wins. > (In fact, PCI spec defined message data length is u64, but as you see, now > msi_msg for whole Linux only have u32...) > Well in that case please define data as __u64, so we don't have surprises later on. -- error compiling committee.c: too many arguments to function