From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 05/11] KVM: Add fields for MSI device assignment Date: Tue, 25 Nov 2008 16:49:49 +0200 Message-ID: <492C108D.6040209@redhat.com> References: <1227095114-13792-1-git-send-email-sheng@linux.intel.com> <1227095114-13792-6-git-send-email-sheng@linux.intel.com> <49292C27.7030206@redhat.com> <200811240951.14758.sheng@linux.intel.com> <492C0FDD.8000609@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35062 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753068AbYKYOt4 (ORCPT ); Tue, 25 Nov 2008 09:49:56 -0500 In-Reply-To: <492C0FDD.8000609@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: >> (In fact, PCI spec defined message data length is u64, but as you >> see, now msi_msg for whole Linux only have u32...) >> > > Well in that case please define data as __u64, so we don't have > surprises later on. > btw, if you agree with this, don't resend; I'll edit the patch. -- error compiling committee.c: too many arguments to function