From: Avi Kivity <avi@redhat.com>
To: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: [Patch 4/5] x86_emulator: add the assembler code for three operands
Date: Tue, 25 Nov 2008 16:59:00 +0200 [thread overview]
Message-ID: <492C12B4.4050700@redhat.com> (raw)
In-Reply-To: <20081125085918.45bb29d2@frecb000711>
Guillaume Thouvenin wrote:
> On Tue, 04 Nov 2008 12:21:30 +0200
> Avi Kivity <avi@redhat.com> wrote:
>
>
>> Guillaume Thouvenin wrote:
>>
>>> Add the assembler code for three operands
>>>
>>>
>>> +/* Instruction has three operands */
>>> +/* In the switch we only implement case 4 because we know that for shld instruction
>>> + * bytes are equal to 4. When eveything will be fine, we will add others cases.
>>>
>>>
>> No, shld is defined for 16, 32, and 64 bit operands. Need to implement
>> those too.
>>
>
> I tried something like:
>
> +/* Instruction has three operands */
> +/* In the switch we only implement case 4 because we know that for shld instruction
> + * bytes are equal to 4. When eveything will be fine, we will add others cases.
> + */
> +#define __emulate_2op_cl(_op,_src,_src2,_dst,_eflags,_by,_bx,_wx,_wy,_lx,_ly,_qx,_qy) \
> + do { \
> + unsigned long _tmp; \
> + \
> + switch((_dst).bytes) { \
> + case 2: \
> + __asm__ __volatile__ ( \
> + _PRE_EFLAGS("0", "5", "2") \
> + "mov %4, %%rcx \n\t" \
> + _op"w %%cl,%3,%1; \n\t" \
> + _POST_EFLAGS("0", "5", "2") \
> + : "=m" (_eflags), "=m" ((_dst).val), \
> + "=&r" (_tmp) \
> + : _wy ((_src).val) , _wy ((_src2).val), "i" (EFLAGS_MASK) \
> + : "%rcx" ); \
> + break; \
> + case 4: \
> + __asm__ __volatile__ ( \
> + _PRE_EFLAGS("0", "5", "2") \
> + "mov %4, %%rcx \n\t" \
> + _op"l %%cl,%3,%1; \n\t" \
> + _POST_EFLAGS("0", "5", "2") \
> + : "=m" (_eflags), "=m" ((_dst).val), \
> + "=&r" (_tmp) \
> + : _ly ((_src).val) , _ly ((_src2).val), "i" (EFLAGS_MASK) \
> + : "%rcx" ); \
> + break; \
> + case 8: \
> + __asm__ __volatile__ ( \
> + _PRE_EFLAGS("0", "5", "2") \
> + "mov %4, %%rcx \n\t" \
> + _op"q %%cl,%3,%1; \n\t" \
> + _POST_EFLAGS("0", "5", "2") \
> + : "=m" (_eflags), "=m" ((_dst).val), \
> + "=&r" (_tmp) \
> + : _ly ((_src).val) , _ly ((_src2).val), "i" (EFLAGS_MASK) \
> + : "%rcx" ); \
> + break; \
> + } \
> + } while (0)
> +
> +#define emulate_2op_cl(_op, _src, _src2, _dst, _eflags) \
> + __emulate_2op_cl(_op, _src, _src2, _dst, _eflags, \
> + "b", "r", "b", "r", "b", "r", "b", "r")
> +
>
> but it doesn't work because shld can not be used with suffix 'l' or 'w'
> etc... Is the solution is to have a single case for all operand size like:
>
>
It does work, perhaps the variables were defined with the wrong size.
This works:
int shld(void)
{
unsigned short w1 = 3, w2 = 5;
unsigned int l1 = 3, l2 = 5;
unsigned long q1 = 3, q2 = 5;
asm("shldw %1, %0" : "+r"(w1) : "r"(w2));
asm("shldl %1, %0" : "+r"(l1) : "r"(l2));
asm("shldq %1, %0" : "+r"(q1) : "r"(q2));
return w1 + l1 + q1;
}
> +#define __emulate_2op_cl(_op,_src,_src2,_dst,_eflags,_wx,_wy) \
> + do { \
> + unsigned long _tmp; \
> + \
> + __asm__ __volatile__ ( \
> + _PRE_EFLAGS("0", "5", "2") \
> + "mov %4, %%rcx \n\t" \
> + _op" %%cl,%3,%1; \n\t" \
> + _POST_EFLAGS("0", "5", "2") \
> + : "=m" (_eflags), "=m" ((_dst).val), \
> + "=&r" (_tmp) \
> + : _wy ((_src).val) , _wy ((_src2).val), "i" (EFLAGS_MASK) \
> + : "%rcx" ); \
> + } while (0)
>
> I tested the code and it seems to work.
>
That's actually better and could be used for the other emulations.
Please disassemble x86_emulate.o and verify that there are three
different shld instructions, one for each register size.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-25 14:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 15:00 [RFC Patch 0/5] x86_emulator: emulate shld and shrd instruction Guillaume Thouvenin
2008-11-03 15:01 ` [Patch 1/5] x86_emulator: Extend the opcode descriptor Guillaume Thouvenin
2008-11-03 15:02 ` [Patch 2/5] x86_emulator: add Src2 decode set Guillaume Thouvenin
2008-11-03 15:03 ` [Patch 3/5] x86_emulator: add a new "implied 1" Src decode type Guillaume Thouvenin
2008-11-03 15:04 ` [Patch 5/5] x86_emulator: add the emulation of shld and shrd instructions Guillaume Thouvenin
2008-11-03 15:05 ` [Patch 4/5] x86_emulator: add the assembler code for three operands Guillaume Thouvenin
2008-11-04 10:21 ` Avi Kivity
2008-11-25 7:59 ` Guillaume Thouvenin
2008-11-25 14:59 ` Avi Kivity [this message]
2008-11-26 11:59 ` Guillaume Thouvenin
2008-11-26 12:50 ` Avi Kivity
2008-12-03 15:00 ` Guillaume Thouvenin
2008-11-04 10:23 ` [RFC Patch 0/5] x86_emulator: emulate shld and shrd instruction Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2008-12-04 13:24 [Patch 0/5] x86_emulator: emulate shld and shrd instructions Guillaume Thouvenin
2008-12-04 13:29 ` [Patch 4/5] x86_emulator: add the assembler code for three operands Guillaume Thouvenin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492C12B4.4050700@redhat.com \
--to=avi@redhat.com \
--cc=guillaume.thouvenin@ext.bull.net \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox