From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm-userspace: fix module build with --kerneldir Date: Wed, 26 Nov 2008 13:14:13 +0200 Message-ID: <492D2F85.5050004@redhat.com> References: <1227621454-24385-1-git-send-email-joerg.roedel@amd.com> <492D27FA.5090707@redhat.com> <20081126115915.4cf3308d@siegfried> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Joerg Roedel To: Maik Hentsche Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40996 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbYKZLOS (ORCPT ); Wed, 26 Nov 2008 06:14:18 -0500 In-Reply-To: <20081126115915.4cf3308d@siegfried> Sender: kvm-owner@vger.kernel.org List-ID: Maik Hentsche wrote: > Avi Kivity wrote: > > >> Can't the version be determined directly from kernedir itself? e.g. >> kerneldir is /lib/modules/$version/build? >> > > How do you get $version if you are crosscompiling? In this case the > usual way of asking uname doesn't work. Instead you somehow need to get > the version of the kernel you're building for from the kernel source > provided in --kerneldir. I don't know any better way than evaluating > UTSRELEASE. > If the user specified $kerneldir, it should be in the form /lib/modules/$version/build, no? If so, then you can extract $version by removing the prefix and suffix from the string. -- error compiling committee.c: too many arguments to function