From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm-userspace: Cleanup user space NMI injection Date: Wed, 26 Nov 2008 13:21:04 +0200 Message-ID: <492D3120.7030902@redhat.com> References: <492AC80E.8080906@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel , "Yang, Sheng" To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51949 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751806AbYKZLVL (ORCPT ); Wed, 26 Nov 2008 06:21:11 -0500 In-Reply-To: <492AC80E.8080906@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Cleanup redundant check for an open NMI window before injecting. This > will no longer be supported by the kernel, and it was broken by design > anyway. > > This change still allows to run the user space against older kernel > modules. > > Hm. For interrupts we need to check, since the interrupt might be deasserted or masked while the window is closed. Is there no way that this can happen for NMIs? -- error compiling committee.c: too many arguments to function