[PATCH] Add KVM version to monitor "info version"

[PATCH] Add KVM version to monitor "info version"

[Bjørn Mork]

Trying to track the current KVM head as closely as possible, I often
find myself wondering which KVM version a particular guest instance is
running.  The attached patch adds this information to the monitor
command "info version":

 (qemu) info version
 0.9.1 (kvm-79)


Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
 qemu/monitor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu/monitor.c b/qemu/monitor.c
index a58a18e..f61fe56 100644
--- a/qemu/monitor.c
+++ b/qemu/monitor.c
@@ -246,7 +246,7 @@ static void do_info(const char *item)
 
 static void do_info_version(void)
 {
-  term_printf("%s\n", QEMU_VERSION);
+  term_printf("%s\n", QEMU_VERSION " (" KVM_VERSION ")");
 }
 
 static void do_info_name(void)

Re: [PATCH] Add KVM version to monitor "info version"

[Daniel P. Berrange]

On Wed, Nov 26, 2008 at 11:22:03AM +0100, Bj?rn Mork wrote:
> Trying to track the current KVM head as closely as possible, I often
> find myself wondering which KVM version a particular guest instance is
> running.  The attached patch adds this information to the monitor
> command "info version":
> 
>  (qemu) info version
>  0.9.1 (kvm-79)

I'd really rather we didn't touch the 'info version' command since it
means we have different syntax from upstream QEMU. If we want KVM
version info exposed, then I'd suggest 'info kvmversion' or some other
new command.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

Re: [PATCH] Add KVM version to monitor "info version"

[Glauber Costa]

On Wed, Nov 26, 2008 at 8:55 AM, Daniel P. Berrange <berrange@redhat.com> wrote:
> On Wed, Nov 26, 2008 at 11:22:03AM +0100, Bj?rn Mork wrote:
>> Trying to track the current KVM head as closely as possible, I often
>> find myself wondering which KVM version a particular guest instance is
>> running.  The attached patch adds this information to the monitor
>> command "info version":
>>
>>  (qemu) info version
>>  0.9.1 (kvm-79)
>
> I'd really rather we didn't touch the 'info version' command since it
> means we have different syntax from upstream QEMU. If we want KVM
> version info exposed, then I'd suggest 'info kvmversion' or some other
> new command.

I believe it fits nicely into info kvm. Instead of enabled/disabled,
we could answer
disabled or kvm-whatever




-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."

Re: [PATCH] Add KVM version to monitor "info version"

[Avi Kivity]

Glauber Costa wrote:
> On Wed, Nov 26, 2008 at 8:55 AM, Daniel P. Berrange <berrange@redhat.com> wrote:
>   
>> On Wed, Nov 26, 2008 at 11:22:03AM +0100, Bj?rn Mork wrote:
>>     
>>> Trying to track the current KVM head as closely as possible, I often
>>> find myself wondering which KVM version a particular guest instance is
>>> running.  The attached patch adds this information to the monitor
>>> command "info version":
>>>
>>>  (qemu) info version
>>>  0.9.1 (kvm-79)
>>>       
>> I'd really rather we didn't touch the 'info version' command since it
>> means we have different syntax from upstream QEMU. If we want KVM
>> version info exposed, then I'd suggest 'info kvmversion' or some other
>> new command.
>>     
>
> I believe it fits nicely into info kvm. Instead of enabled/disabled,
> we could answer
> disabled or kvm-whatever
>
>   

(qemu) info kvm
enabled (kvm-123)

or

(qemu) info kvm
enabled
version kvm-123

May be easier to parse, and more backwards compatible.

-- 
error compiling committee.c: too many arguments to function

Re: [PATCH] Add KVM version to monitor "info version"

[Bjørn Mork]

Avi Kivity <avi@redhat.com> writes:

> (qemu) info kvm
> enabled (kvm-123)
>
> or
>
> (qemu) info kvm
> enabled
> version kvm-123
>
> May be easier to parse, and more backwards compatible.

Something like this then?

The attached patch adds KVM version to the monitor command "info kvm":
    
  (qemu) info kvm
  kvm support: enabled
  kvm version: kvm-80
    
Signed-off-by: Bjørn Mork <bjorn@mork.no>

diff --git a/qemu/monitor.c b/qemu/monitor.c
index 3948aae..3831789 100644
--- a/qemu/monitor.c
+++ b/qemu/monitor.c
@@ -1297,6 +1297,7 @@ static void do_info_kvm(void)
 	term_printf("enabled\n");
     else
 	term_printf("disabled\n");
+    term_printf("kvm version: "  KVM_VERSION "\n");
 #else
     term_printf("kvm support: not compiled\n");
 #endif