Re: [Patch 4/5] x86_emulator: add the assembler code for three operands

[Avi Kivity <avi@redhat.com>]

Guillaume Thouvenin wrote:
> It's the only code with shld instruction. I don't see how you can have
> three different shld instructions here. I'm sure that I'm missing
> something here because for me, when we emulate the shld instruction, the
> code produced is the same. I mean that src.val and dst.val are always
> unsigned long and I don't see why register size are important here. In
> fact I don't understand why we need to use the switch ((_dst).bytes)
> for the other emulations.
>   

The flags vary according to operand size.  For example, shld $1, %bx, 
%ax where %ax == 0x8000 will set eflags.cf, but shld $1, %ebx, %eax , 
with the same arguments, will not.

-- 
error compiling committee.c: too many arguments to function