From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm-devel <kvm@vger.kernel.org>, "Yang, Sheng" <sheng.yang@intel.com>
Subject: Re: [PATCH] kvm-userspace: Cleanup user space NMI injection
Date: Wed, 26 Nov 2008 18:26:24 +0200 [thread overview]
Message-ID: <492D78B0.7080502@redhat.com> (raw)
In-Reply-To: <492D3674.1070003@siemens.com>
Jan Kiszka wrote:
>> Hm. For interrupts we need to check, since the interrupt might be
>> deasserted or masked while the window is closed.
>>
>> Is there no way that this can happen for NMIs?
>>
>
> In our emulation, but I also think in real life, there is no way to
> deassert an NMI. Therefore, our user space API just sets the nmi_pending
> flag. Masking of NMIs (due to mov ss etc.) is handled by the NMI
> injection code, and this has to happen in kernel anyway as the other NMI
> sources (APIC and IOAPIC) do not bother about the NMI windows as well.
>
I think you're right, and applied the patch. Thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-11-26 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 15:28 [PATCH] kvm-userspace: Cleanup user space NMI injection Jan Kiszka
2008-11-26 11:21 ` Avi Kivity
2008-11-26 11:43 ` Jan Kiszka
2008-11-26 16:26 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492D78B0.7080502@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox