From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: header-sync: fix to work with 2.6.28 kernel Date: Wed, 26 Nov 2008 18:27:28 +0200 Message-ID: <492D78F0.3030209@redhat.com> References: <1227532881.7605.35.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53629 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbYKZQ1g (ORCPT ); Wed, 26 Nov 2008 11:27:36 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAQGRZxr002709 for ; Wed, 26 Nov 2008 11:27:35 -0500 In-Reply-To: <1227532881.7605.35.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > If you run header-sync against a kernel which has asm/kvm.h but not > e.g. asm/vmx.h then $(wildcard $(headers-new)) returns a string with > expanded kvm.h path and the vmx.h glob removed. We then pass the > original globs to rsync causing that to fail when vmx.h can't be > found: > > rsync: link_stat ".../asm/vmx*.h" failed: No such file or directory (2) > > Fix by passing the expanded paths returned by the wildcard function to > rsync. > Applied, thanks. -- error compiling committee.c: too many arguments to function