Re: [PATCH] KVM: Qemu: push_nmi should be only used by I386 Arch.

Hollis Blanchard
2008-12-01T23:18:10Z

On Tue, 2008-12-02 at 00:02 +0100, Jan Kiszka wrote:
> >
> > Guys, we already have stubs for this (although they've been turned into
> > dead code). Jan broke IA64 and PowerPC builds when he renamed
> > "kvm_arch_try_push_nmi" to "kvm_arch_push_nmi", and the obvious fix is
> > to update the stubs to match. That avoids all these ifdefs and
> > associated problems.
>
> Ouch - I'm sorry.

Well, it happens, but I do wish that more people would use cscope or
even grep to find all users of a symbol.

I also wish that Avi would get his PPC box working so he could catch
build breaks like these. Cross-compilers would do as well.

I would also like a pony.

> > Avi, could you revert a8d12f98755be9330fcde055134511f76ecaa538 please?
> >
>
> Here is a patch that reverts change and fixes the root of the issue.

Acked-by: Hollis Blanchard <hollisb@us.ibm.com>

--
Hollis Blanchard
IBM Linux Technology Center