From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Rousseau Subject: Re: [PATCH 06/12] kvm: qemu: device-assignment: cleanup irq assignment error messages Date: Fri, 28 Nov 2008 14:05:00 -0500 Message-ID: <493040DC.4010102@gmail.com> References: <> <1227892250-14386-1-git-send-email-markmc@redhat.com> <1227892250-14386-2-git-send-email-markmc@redhat.com> <1227892250-14386-3-git-send-email-markmc@redhat.com> <1227892250-14386-4-git-send-email-markmc@redhat.com> <1227892250-14386-5-git-send-email-markmc@redhat.com> <1227892250-14386-6-git-send-email-markmc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from yw-out-2324.google.com ([74.125.46.31]:20602 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752571AbYK1TFE (ORCPT ); Fri, 28 Nov 2008 14:05:04 -0500 Received: by yw-out-2324.google.com with SMTP id 9so614548ywe.1 for ; Fri, 28 Nov 2008 11:05:03 -0800 (PST) In-Reply-To: <1227892250-14386-6-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > Replace perror() usage with sane error message. > > Signed-off-by: Mark McLoughlin > --- > qemu/hw/device-assignment.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c > index 2b2ef68..b39617a 100644 > --- a/qemu/hw/device-assignment.c > +++ b/qemu/hw/device-assignment.c > @@ -473,9 +473,10 @@ void assigned_dev_update_irq(PCIDevice *d) > assigned_irq_data.host_irq = assigned_dev->real_device.irq; > r = kvm_assign_irq(kvm_context, &assigned_irq_data); > if (r < 0) { > - perror("assigned_dev_update_irq"); > - fprintf(stderr, "Are you assigning a device " > - "that shares IRQ with some other device?\n"); > + fprintf(stderr, "Failed to assign irq for \"%s\": %s\n", > + adev->name, strerror(-r)); > + fprintf(stderr, "Perhaps you re you assigning a device " Typo. > + "that shares IRQ with another device?\n"); > pci_unregister_device(&assigned_dev->dev); > /* FIXME: Delete node from list */ > continue; -John