From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/5] KVM: remove the IRQ ACK notifier assertions Date: Tue, 02 Dec 2008 14:39:52 +0200 Message-ID: <49352C98.8090700@redhat.com> References: <1228139817.3870.30.camel@blaa> <1228139869-5848-1-git-send-email-markmc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42203 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753445AbYLBMjz (ORCPT ); Tue, 2 Dec 2008 07:39:55 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mB2Cdtcg017319 for ; Tue, 2 Dec 2008 07:39:55 -0500 In-Reply-To: <1228139869-5848-1-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > We will obviously never pass a NULL struct kvm_irq_ack_notifier* to > this functions. They are always embedded in the assigned device > structure, so the assertion add nothing. > > The irqchip_in_kernel() assertion is very out of place - clearly > this little abstraction needs to know nothing about the upper > layer details. > Applied all, thanks. -- error compiling committee.c: too many arguments to function