From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/5] KVM: add KVM_USERSPACE_IRQ_SOURCE_ID assertions Date: Tue, 02 Dec 2008 14:41:46 +0200 Message-ID: <49352D0A.6060200@redhat.com> References: <1228139817.3870.30.camel@blaa> <1228139869-5848-1-git-send-email-markmc@redhat.com> <1228139869-5848-2-git-send-email-markmc@redhat.com> <1228139869-5848-3-git-send-email-markmc@redhat.com> <1228139869-5848-4-git-send-email-markmc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42230 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753287AbYLBMlu (ORCPT ); Tue, 2 Dec 2008 07:41:50 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mB2CfmkL017954 for ; Tue, 2 Dec 2008 07:41:48 -0500 In-Reply-To: <1228139869-5848-4-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > Make sure kvm_request_irq_source_id() never returns > KVM_USERSPACE_IRQ_SOURCE_ID. > > Likewise, check that kvm_free_irq_source_id() never accepts > KVM_USERSPACE_IRQ_SOURCE_ID. > An alternative way to do this is to drop the distinction KVM_USERSPACE_IRQ_SOURCE_ID has, and simply allocate it via the normal irq source id allocation API (and store it in struct kvm). That's not worth the churn though. -- error compiling committee.c: too many arguments to function