Re: [PATCH] Kvm: Qemu: save nvram

[Avi Kivity <avi@redhat.com>]

Daniel P. Berrange wrote:
> On Tue, Dec 02, 2008 at 10:25:49AM +0800, Zhang, Yang wrote:
>   
>> This patch to save the nvram. It save the nvram by specify the arg of 
>> -name.And the saved file named by the arg. If do not specify the arg,
>> it will not save the nvram
>>     
>
> I think we might be better off having an explicit command line arg for nvram
> path rather than hardcoding the directory, because there may well be times
> where you want to have nvram saved, but don't want to specify -name, and
> vica-verca. 
>
>   -nvram foo.data
>
> could prepend a default directory of $localstatedir/lib/qemu/nvram, where
> $localstatedir  is set from 'configure' script, or
>
>   -nvram /some/path/foo.data
>
> would use the explicit path given.
>   

I prefer current directory if relative path is given.  Since we 
encourage running qemu as an unprivileged user, and we don't want a 
world-writable directory, each user will have to provide a private 
storage location.

-- 
error compiling committee.c: too many arguments to function