From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Kvm: Qemu: save nvram Date: Tue, 02 Dec 2008 15:01:20 +0200 Message-ID: <493531A0.2040501@redhat.com> References: <10C63FAD690C13458F0B32BCED571F14021760D4@pdsmsx502.ccr.corp.intel.com> <20081202103145.GC25599@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Zhang, Yang" , "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" , "avi@readhat.com" , "Zhang, Xiantao" To: "Daniel P. Berrange" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:49419 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753320AbYLBNBZ (ORCPT ); Tue, 2 Dec 2008 08:01:25 -0500 In-Reply-To: <20081202103145.GC25599@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Daniel P. Berrange wrote: > On Tue, Dec 02, 2008 at 10:25:49AM +0800, Zhang, Yang wrote: > >> This patch to save the nvram. It save the nvram by specify the arg of >> -name.And the saved file named by the arg. If do not specify the arg, >> it will not save the nvram >> > > I think we might be better off having an explicit command line arg for nvram > path rather than hardcoding the directory, because there may well be times > where you want to have nvram saved, but don't want to specify -name, and > vica-verca. > > -nvram foo.data > > could prepend a default directory of $localstatedir/lib/qemu/nvram, where > $localstatedir is set from 'configure' script, or > > -nvram /some/path/foo.data > > would use the explicit path given. > I prefer current directory if relative path is given. Since we encourage running qemu as an unprivileged user, and we don't want a world-writable directory, each user will have to provide a private storage location. -- error compiling committee.c: too many arguments to function