From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH] extboot: properly set int 0x13 return value
Date: Tue, 02 Dec 2008 08:20:35 -0600
Message-ID: <49354433.7060706@us.ibm.com>
References: <1228161692-13200-1-git-send-email-glommer@redhat.com> <4935264A.4050006@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Glauber Costa <glommer@redhat.com>, kvm@vger.kernel.org,
	qemu-devel@nongnu.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e38.co.us.ibm.com ([32.97.110.159]:37043 "EHLO
	e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752146AbYLBOUx (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 2 Dec 2008 09:20:53 -0500
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106])
	by e38.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id mB2EJnHs011193
	for <kvm@vger.kernel.org>; Tue, 2 Dec 2008 07:19:49 -0700
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mB2EKej6086086
	for <kvm@vger.kernel.org>; Tue, 2 Dec 2008 07:20:42 -0700
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mB2EKdtA006851
	for <kvm@vger.kernel.org>; Tue, 2 Dec 2008 07:20:40 -0700
In-Reply-To: <4935264A.4050006@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
> Applied, thanks.
>
>>  
>> -.macro clc
>> -    push %ax
>> -    pushf
>> -    pop %ax
>> -    and $(~FLAGS_CF), %ax
>> -    push %ax
>> -    popf
>> -    pop %ax
>>   
>
> Anthony, any reason you did not use the 'clc' instruction instead of a 
> macro?

Propensity for pain?

I have no idea.  I assume I had a reason at the time.  Probably debug 
related.

Regards,

Anthony Liguori