From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] [v2] Remove TARGET_PAGE_SIZE from virtio interface Date: Thu, 04 Dec 2008 13:58:58 -0600 Message-ID: <49383682.10309@us.ibm.com> References: <1227650239-14162-1-git-send-email-aliguori@us.ibm.com> <1228155570-9913-1-git-send-email-hollisb@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, Avi Kivity , kvm@vger.kernel.org To: Hollis Blanchard Return-path: Received: from e8.ny.us.ibm.com ([32.97.182.138]:47342 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756544AbYLDT7A (ORCPT ); Thu, 4 Dec 2008 14:59:00 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e8.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id mB4JsNcu028204 for ; Thu, 4 Dec 2008 14:54:23 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mB4JwxEs161520 for ; Thu, 4 Dec 2008 14:58:59 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mB4JwV31006417 for ; Thu, 4 Dec 2008 14:58:32 -0500 In-Reply-To: <1228155570-9913-1-git-send-email-hollisb@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Hollis Blanchard wrote: > TARGET_PAGE_SIZE should only be used internal to qemu, not in guest/host > interfaces. The virtio frontend code in Linux uses two constants (PFN shift > and vring alignment) for the interface, so update qemu to match. > > I've tested this with PowerPC KVM and confirmed that it fixes virtio problems > when using non-TARGET_PAGE_SIZE pages in the guest. > Applied. Thanks. Regards, Anthony Liguori