From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] do boundary check based on absolute value Date: Thu, 04 Dec 2008 16:36:54 -0600 Message-ID: <49385B86.8090604@codemonkey.ws> References: <1228427046-28875-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from mail-qy0-f11.google.com ([209.85.221.11]:59245 "EHLO mail-qy0-f11.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789AbYLDWg7 (ORCPT ); Thu, 4 Dec 2008 17:36:59 -0500 Received: by qyk4 with SMTP id 4so5442592qyk.13 for ; Thu, 04 Dec 2008 14:36:58 -0800 (PST) In-Reply-To: <1228427046-28875-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > For backward operations, dstpitch and srcpitch can > be negative. This leads BLTUNSAFE macro into an > overflow, and as a result, it avoids performing > operations that are perfectly valid. > > The visible effect that led to that patch was the gnome-panel > bar in Fedora10. Before this patch, you could see garbage > clobbering a big portion of the bar. > > After this patch, this garbage is gone. > > Applied. Thanks. Regards, Anthony Liguori