From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] virtio: make PCI devices take a virtio_pci module ref Date: Fri, 05 Dec 2008 09:43:23 -0600 Message-ID: <49394C1B.2010001@us.ibm.com> References: <1228394671.3732.77.camel@blaa> <49385DB7.4060306@gmail.com> <4938EE0B.8020501@msgid.tls.msk.ru> <493929D2.4070900@gmail.com> <1228488921.3858.25.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jiri Slaby , Michael Tokarev , Rusty Russell , linux-kernel , kvm To: Mark McLoughlin Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:54238 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752431AbYLEPnb (ORCPT ); Fri, 5 Dec 2008 10:43:31 -0500 In-Reply-To: <1228488921.3858.25.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > On Fri, 2008-12-05 at 14:17 +0100, Jiri Slaby wrote: > > +static void virtio_pci_release_dev(struct device *dev) > +{ > +} > + > /* A PCI device has it's own struct device and so does a virtio device so > * we create a place for the virtio devices to show up in sysfs. I think it > * would make more sense for virtio to not insist on having it's own device. */ > static struct device virtio_pci_root = { > .parent = NULL, > .bus_id = "virtio-pci", > + .release = virtio_pci_release_dev, > }; > Actually, we should be able to delete this virtio_pci_root entirely. The device is a dummy one anyway. Regards, Anthony Liguori > /* Convert a generic virtio device to our structure */ > @@ -328,6 +333,7 @@ static int __devinit virtio_pci_probe(struct pci_dev *pci_dev, > return -ENOMEM; > > vp_dev->vdev.dev.parent = &virtio_pci_root; > + vp_dev->vdev.dev.release = virtio_pci_release_dev; > vp_dev->vdev.config = &virtio_pci_config_ops; > vp_dev->pci_dev = pci_dev; > INIT_LIST_HEAD(&vp_dev->virtqueues); >