kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm testsuite: Add test for 'shld' instruction
Date: Fri, 05 Dec 2008 19:17:17 +0200	[thread overview]
Message-ID: <4939621D.9090200@redhat.com> (raw)
In-Reply-To: <20081204143822.71bd46da@frecb000711>

Guillaume Thouvenin wrote:
> Add 'shld' instruction test in real mode test harness. 
>
>   
Applied, thanks.

> Avi, on my computer this test is broken but the problem seems to be
> elsewhere because test_shld() works fine alone. I'm inspecting other
> test. Used alone shld gives the right values (shift is ok and bits are
> added).
>   

I see a different failure, due to leakage of register values from one 
test to another.  I fixed it up.  If you see the failure after the fix, 
we can reexamine it.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2008-12-05 17:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04 13:38 [PATCH] kvm testsuite: Add test for 'shld' instruction Guillaume Thouvenin
2008-12-05 17:17 ` Avi Kivity [this message]
2008-12-10  8:49   ` Guillaume Thouvenin
  -- strict thread matches above, loose matches on Subject: below --
2008-11-03 15:05 Guillaume Thouvenin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4939621D.9090200@redhat.com \
    --to=avi@redhat.com \
    --cc=guillaume.thouvenin@ext.bull.net \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).