From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm testsuite: Add test for 'shld' instruction Date: Fri, 05 Dec 2008 19:17:17 +0200 Message-ID: <4939621D.9090200@redhat.com> References: <20081204143822.71bd46da@frecb000711> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Guillaume Thouvenin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54461 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384AbYLERRl (ORCPT ); Fri, 5 Dec 2008 12:17:41 -0500 In-Reply-To: <20081204143822.71bd46da@frecb000711> Sender: kvm-owner@vger.kernel.org List-ID: Guillaume Thouvenin wrote: > Add 'shld' instruction test in real mode test harness. > > Applied, thanks. > Avi, on my computer this test is broken but the problem seems to be > elsewhere because test_shld() works fine alone. I'm inspecting other > test. Used alone shld gives the right values (shift is ok and bits are > added). > I see a different failure, due to leakage of register values from one test to another. I fixed it up. If you see the failure after the fix, we can reexamine it. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.