From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Use guards in virtio-net for easier upstream merging (v2) Date: Fri, 05 Dec 2008 19:40:59 +0200 Message-ID: <493967AB.7090406@redhat.com> References: <1228403617-13389-1-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Mark McLoughlin To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53484 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757513AbYLERlA (ORCPT ); Fri, 5 Dec 2008 12:41:00 -0500 In-Reply-To: <1228403617-13389-1-git-send-email-aliguori@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > This gets virtio-net into an upstream acceptable state. This includes > introducing USE_KVM guards for IO thread notification (where did > qemu_service_io() go?). It also includes introducing TAP_VNET_HDR which is for > code that relies on the tap vnet support that is not currently in upstream QEMU. > > Finally, it drops packets if not ready to receive. This is unnecessary in > kvm-userspace but necessary in QEMU. > > Since v1, I enable tap vnet by default, and pass the buffer size to > virtio_net_receive() as suggested by Mark. > Applied, thanks. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.